Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label Templates: document all the new available variables #378

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

fgiudici
Copy link
Member

Also deprecate the old ones.

Fixes: #374

Feature naming is "Label Templates".
Drop "template labels".
"templated labels" can be allowed.

Signed-off-by: Francesco Giudici <[email protected]>
@fgiudici fgiudici requested a review from a team as a code owner September 17, 2024 17:28
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for elemental-docs-staging ready!

Name Link
🔨 Latest commit a2707ae
🔍 Latest deploy log https://app.netlify.com/sites/elemental-docs-staging/deploys/66e9be3aba87220008ec2d2e
😎 Deploy Preview https://deploy-preview-378--elemental-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kkaempf
Copy link
Contributor

kkaempf commented Sep 18, 2024

What does "deprecate the old ones" mean ?
Are they still available (for a smooth transition) or were they removed (breaking existing setups) ? 🤔

Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good job 👍

@fgiudici
Copy link
Member Author

What does "deprecate the old ones" mean ? Are they still available (for a smooth transition) or were they removed (breaking existing setups) ? 🤔

They are still available, quoting: "While these variable families are still correctly rendered in current Elemental Operator versions, their support will be removed in future Elemental Operator releases."
We still support them but we want users to use the new ones 😉

@fgiudici fgiudici merged commit c8dd7d2 into rancher:main Sep 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document all the available Label Templates variables
3 participants